Reusable Blocks: Use React 18 rendering for import dropdown #48244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
approved these changes
Feb 20, 2023
|
Size Change: +3 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5bebf3f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4230133680
|
734c013 to
5bebf3f
Compare
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: dd2d905 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates reusable blocks to use the React 18 rendering for the import from JSON form.
Why?
We already use React 18 concurrent rendering everywhere. This will also remove the following warning from the console:
How?
We're updating to use the new
createRoot().render()API instead of the legacyrender().Testing Instructions
/wp-admin/edit.php?post_type=wp_blockTesting Instructions for Keyboard
None
Screenshots or screencast
None