Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Disable lazy term meta loading render_block_core_template_part. #48000

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Performance: Disable lazy term meta loading render_block_core_template_part. #48000

merged 4 commits into from
Feb 23, 2023

Conversation

spacedmonkey
Copy link
Member

What?

Follow on from #47999.

Disable lazy loading term meta for render_block_core_template_part.

Before

Screenshot 2023-02-13 at 00 43 20

After

Screenshot 2023-02-13 at 00 55 55

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@spacedmonkey spacedmonkey self-assigned this Feb 13, 2023
@spacedmonkey spacedmonkey added the [Type] Performance Related to performance efforts label Feb 13, 2023
felixarntz
felixarntz reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacedmonkey LGTM.

However, see #47999 (review): Can you please add a note on why this change is crucial for performance?

packages/block-library/src/template-part/index.php Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Feb 17, 2023 •
edited
Loading

Flaky tests detected in a734898.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4220404559
📝 Reported issues:

draganescu
draganescu approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spacedmonkey
Copy link
Member Author

Any idea why the performance tests are failing. This seems unrelated.

@spacedmonkey spacedmonkey enabled auto-merge (squash) February 23, 2023 16:57
@spacedmonkey spacedmonkey merged commit 80cd581 into trunk Feb 23, 2023
@spacedmonkey spacedmonkey deleted the fix/render_block_core_template_part-prime-term-meta branch February 23, 2023 17:22
@github-actions github-actions bot added this to the Gutenberg 15.3 milestone Feb 23, 2023
@spacedmonkey spacedmonkey added the Needs PHP backport Needs PHP backport to Core label May 2, 2023
@spacedmonkey
Copy link
Member Author

Backport ticket. https://core.trac.wordpress.org/ticket/58230

@ramonjd ramonjd removed the Needs PHP backport Needs PHP backport to Core label Jun 2, 2023
@Mamaduka Mamaduka mentioned this pull request Nov 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draganescu draganescu draganescu approved these changes

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@getdave getdave Awaiting requested review from getdave

@Copons Copons Awaiting requested review from Copons

@david-szabo97 david-szabo97 Awaiting requested review from david-szabo97

@epiqueras epiqueras Awaiting requested review from epiqueras

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

@spacedmonkey spacedmonkey

Labels
[Type] Performance Related to performance efforts
Projects
None yet
Milestone
Gutenberg 15.3
Development

Successfully merging this pull request may close these issues.
4 participants
@spacedmonkey @draganescu @felixarntz @ramonjd