Make getLastInsertedBlocksClientIds selector private #47638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 1, 2023
|
Size Change: +11 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 25c2365. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4062863673
|
Mamaduka
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Make selector private and update docs * Unlock selector at point of usage
|
I just cherry-picked this PR to the release/15.1 branch to get it included in the next release: 8a907ca |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Makes the
getLastInsertedBlocksClientIdsselector introduced in #46531 a private selector.Why?
In preparation for WP 6.2 we need to audit APIs that should be experimental.
In #46531 I introduced a new selector. This should probably be experimental as it's very new and unproven and the API may still be in flux as evidenced by the changes required to it since it was originally added.
How?
Use the new
lock/unlockAPI to make an experimental selector following the pattern already in place within the block editor package.Testing Instructions
Check tests pass