Migrate from TextControl to NumberControl to remove margin overrides #47160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookewp
commented
Jan 14, 2023
| label={ __( 'Order' ) } | ||
| value={ value } | ||
| onChange={ setUpdatedOrder } | ||
| size={ 6 } | ||
| labelPosition="side" |
There was a problem hiding this comment.
Because NumberControl has an option for a side label, the label ends up being more centered than it does in trunk.
And these changes remove the need for a CSS file at all for this component.
There was a problem hiding this comment.
This is what I'm seeing. Does it need a FlexBlock wrapper again?
There was a problem hiding this comment.
Oh, nice find! It's aligned in FireFox but I see this in Safari now. I'll update it and check a few browsers to double-check. 👍
brookewp
commented
Jan 14, 2023
| .block-editor-image-size-control__height { | ||
| margin-bottom: 0.5em; | ||
|
|
||
| // Fix the text and placeholder text being misaligned in Safari |
There was a problem hiding this comment.
I removed CSS that was added three years ago for a Safari fix, but when testing Safari with the removed code, it looked the same as other browsers.
8a95452 to
c10cd1c
Compare
|
Size Change: -207 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in c10cd1c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3917819816
|
49 tasks
mirka
reviewed
Jan 26, 2023
packages/block-editor/src/components/image-size-control/index.js
Outdated
Show resolved
Hide resolved
| <VStack className="block-editor-image-size-control" spacing="0"> | ||
| <p>{ __( 'Image dimensions' ) }</p> | ||
|
|
||
| <HStack align="baseline" spacing="3"> |
There was a problem hiding this comment.
To keep the height input aligned. Otherwise, it looks like this:
There was a problem hiding this comment.
So it isn't needed now that we dealt with the bottom margin problem?
There was a problem hiding this comment.
@mirka, can you clarify what you mean by 'it' in your question? I'm not sure I understand so I just wanted to confirm if I need to remove anything before merging. 🙂
There was a problem hiding this comment.
Ah sorry, I meant the align="baseline".
There was a problem hiding this comment.
No worries! It is needed, from what I can tell, so it doesn't end up looking like the screenshot above.
| label={ __( 'Order' ) } | ||
| value={ value } | ||
| onChange={ setUpdatedOrder } | ||
| size={ 6 } | ||
| labelPosition="side" |
| label={ __( 'Order' ) } | ||
| value={ value } | ||
| onChange={ setUpdatedOrder } | ||
| size={ 6 } | ||
| labelPosition="side" |
There was a problem hiding this comment.
This is what I'm seeing. Does it need a FlexBlock wrapper again?
c10cd1c to
25e09c9
Compare
mirka
approved these changes
Jan 31, 2023
| <VStack className="block-editor-image-size-control" spacing="0"> | ||
| <p>{ __( 'Image dimensions' ) }</p> | ||
|
|
||
| <HStack align="baseline" spacing="3"> |
There was a problem hiding this comment.
So it isn't needed now that we dealt with the bottom margin problem?
25e09c9 to
2ea705e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updated
TextControlinstances using type number toNumberControlcomponent.Why?
While working on this project to remove margin overrides, I thought it made more sense to use NumberControl which also helped with removing overrides.
How?
By adding NumberControl, HStack, and VStack and removing unnecessary CSS.
Testing Instructions
ImageSizeControl
Before
After
InlineUI
Before
After
PageAttributesOrder
Before
After