Allow not updating selection when dispatching replaceBlock(s) #46611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +71 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Closing as no longer necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allow for the
replaceBlock/replaceBlocksaction to not update the selection. This marries with the approach ininsertBlocksandreplaceInnerBlocks.Why?
The action already allows for defining an index to be selected following the replacement of the blocks via the
indexToSelectargument. However if this isn't provided then the reducer will automatically default to selecting the last block in the replaced set.However, with the advent of offcanvas editing (relevant PR) there are occasions where when inserting / replacing blocks we do not want to update the selection in the canvas.
For example, in #46582 we want to replace a
core/navigation-linkblock with acore/navigation-submenublock but not select the block once it's been inserted. With the current action that is not possible.How?
This PR enables the functionality by repurposing the
indexToSelectargument. If it is explicitly set tofalsethen the reducer will return an empty object which causes the selection not to be updated.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast