Navigation Block: Add social link singular to list of blocks to be allowed #46374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this fix is out I will write Unit tests to provide full coverage. |
|
Also note this doesn't solve the root cause which was that whilst |
This was referenced Dec 7, 2022
ajlende
pushed a commit
that referenced
this pull request
Dec 7, 2022
)" This reverts commit 394590b.
scruffian
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Revert "Handle innerContent too when removing innerBlocks (#46377)" This reverts commit 181b383. * Revert "Add social link singular to list of blocks to be allowed (#46374)" This reverts commit 394590b. * Revert "Recursively remove Navigation block’s from appearing inside Navigation block on front of site (#46279)" This reverts commit afc8b42. * Refactor ul code for readability * Refactor li wrapper conditional * Prevent rendering nav refs that have already been seen * Fix PHP lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #46371 by allowing singular Social Link block within the Social Links block.
This bug was introduced by #46279.
Why?
Singular social links blocks should be allowed in a social links plural block.
How?
Add to whitelist.
Testing Instructions
Add Nav block. Add social links block. Add one or more social link (singular) blocks.
Check no errors on front end as reported on Issue #46371.
Testing Instructions for Keyboard
Screenshots or screencast