Empty Theme: Add the $schema property in theme.json and rename template directories
#46300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate directories
|
Nice work, these changes were also made in the emptytheme repo itself so they should match what's here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes the following two changes to the Empty Theme:
$schemaproperty intheme.jsonblock-templatestotemplates,block-template-partstotemplate-partsWhy?
This may not be true for all contributors, but I activate Empty Theme when isolating the cause. I also temporarily add properties when testing the reproducibility of global style-related defects, etc. In those cases, I think it would be useful to have auto-completion and validation.
As for directory names, they have changed in WordPress 5.9. The Gutenberg plugin supports WordPress versions 5.9 and above, so renaming should not be a problem now.
Testing Instructions
theme.jsonin the code editor and confirm that auto-completion and validation are performed.