Migrate a11y e2e tests to Playwright #46038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
1020339 to
b8334d4
Compare
|
Flaky tests detected in b8334d4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3946977911
|
aristath
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38851.
Related: #42653
What?
Migrates the
a11yE2E tests to Playwright.For now, it's a Draft PR because running the tests also with Firefox and Webkit surfaced new failures of the Constrained tabbing component. The previous tests passed because they only ran with Chromium.
Failures appear to be related to different native browser behaviors that aren't taken into account by the current implementation. Will create a new issue.
Why?
Part of the migration plan. Also, these tests need to run on multiple browsers as the tested features rely on native browsers behavior.
How?
packages/e2e-tests/specs/editor/various/a11y.test.jstest/e2e/specs/editor/various/a11y.spec.jsTesting Instructions
To run the tests with a visible browser window:
npm run test:e2e:playwright -- --headed editor/various/a11y.spec.jsheadless mode:
npm run test:e2e:playwright -- editor/various/a11y.spec.jsThe 4 test will run in Chromium, Webkit, and Firefox (for a total of 12 tests executed).
Screenshots or screencast