Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better categories handler #45695

Conversation

AllTerrainDeveloper
Copy link

@AllTerrainDeveloper AllTerrainDeveloper commented Nov 10, 2022

What?

Improving categories handler in the Gutenberg editor.

Why?

It just makes it way better to handler categories

How?

I'm using a ComboboxControl filled checkboxes in order to select the categories. Also added an easy way of removing them.

Testing Instructions

Fill your blog with a lot of categories
Create a post and play around with the categories selector.

Screenshots

image

BEFORE AFTER
old categories new categories

@codesandbox
Copy link

codesandbox bot commented Nov 10, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Nov 10, 2022
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @AllTerrainDeveloper! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@Mamaduka Mamaduka added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Nov 10, 2022
@Mamaduka
Copy link
Member

Thanks for contributing, @AllTerrainDeveloper!

It just makes it way better to handler categories

Can you elaborate more on this?

@AllTerrainDeveloper
Copy link
Author

Thanks for contributing, @AllTerrainDeveloper!

It just makes it way better to handler categories

Can you elaborate more on this?

Gamaryoba @Mamaduka! Maybe I went quite ahead of "way better" but it feels simpler and nicer for me. With the shortcut of removing categories. Here is a comparison table showing a gif for both cases.

BEFORE AFTER
old categories new categories

@paaljoachim
Copy link
Contributor

Hey @AllTerrainDeveloper Daniel

Thank you for working on this feature!
I will bring in this issue:
Using multi select in a drop down?
#1044

I will also ping @jasmussen @ntsekouras and @rmorse as they might have some feedback on this PR.

@jasmussen
Copy link
Contributor

Just to be sure I'm understanding this right, this puts the entire hierarchical category handling inside the dropdown, correct? While I can see how that improves compression and simplicity, especially for sites with hundreds of categories, I would worry that it might conflate categories with tags for the majority of users that might have only a few categories.

@paaljoachim
Copy link
Contributor

paaljoachim commented Nov 16, 2022

Hi @AllTerrainDeveloper Daniel

It would be better to focus on tackling this issue:
Query Block - more advanced / multi select query options
#30706

As I do not believe there are any plans to adjust how categories in general work today.
It is not likely something that will be adjusted for the time being.

@carolinan carolinan removed the Needs Design Feedback Needs general design feedback. label Jan 14, 2025
Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: General Interface, First-time Contributor.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@carolinan
Copy link
Contributor

I am closing this based on the feedback left in the comments and because there has been no activity since 2022.

@carolinan carolinan closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants