Tests/optimize perf tests #45327
Closed
Tests/optimize perf tests #45327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #23818 we added the `--ci` command-line arg to the performance test runner to detect if we were running in a CI context. However, if our script is running inside Github Actions then the `ENV['CI']` value will be set. In this patch we're removing the command-line arg and relying on the `ENV` value in order to simplify the script's interface. This is part of a larger refactor to the performance test script and is an early change to minimize subsequent larger changes.
In this patch we're refactoring how the performance tests are configured, relying on the ENV values set by Github Actions and adding new semantic terms for existing implicit conditions. Additionally, the custom `git` abstraction has been removed and replaced with `SimpleGit` for a more concrete represetnation of what is being performed during the test setup. This change will enable more complicated uses of `git` for optimizing the run script, and by moving out of the abstraction it will minimize any changes based on that kind of `git` usage. There should be no functional changes in this patch and only the code surrounding test setup should change. The term "branch" is replaced in a few places with "ref" since this script is designed to accept any `git` ref pointing to commits, and in fact has been in daily use with a mix of tags, commit SHAs, and branch names.
When running the performance tests in Github Actions we start with a local shallow clone of the Gutenberg repo from a previous step. Previously we've been cloning a new copy of the repo from Github directly. In this patch we're starting each checkout by looking first in the local clone if it's already available. If not then we'll reach out to the remote repo on Github.
We don't use the types we build during the performance test runs, but generating them slows us down. Let's skip over that step to cut out unecessary delay.
|
Size Change: -12 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Closing because it's too hard to keep this branch maintained. Check in the "revert" branch #45175 to see how the sum total of the optimizations has impacted the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent PR for sum of perf test optimizations
Please ignore this for now.