-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List: allow pasting pre/code #45016
Merged
Merged
List: allow pasting pre/code #45016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Block] List
Affects the List Block
[Block] Code
Affects the Code Block
[Block] Preformatted
Affects the Preformatted Block - used for showing preformatted text
labels
Oct 17, 2022
Size Change: +200 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
fix/paste-pre-in-list
branch
from
November 30, 2022 08:35
8ca9146
to
75c5e8b
Compare
Small, straightforward, and isolated change with a test. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Code
Affects the Code Block
[Block] List
Affects the List Block
[Block] Preformatted
Affects the Preformatted Block - used for showing preformatted text
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #9476.
This PR does two things:
When transforming the code or preformatted block to a paragraph, make sure line breaks are converted to HTML, otherwise it becomes a single line.
Use these transforms to convert the resulting paragraph to list items when pasted in a list block.
Why?
Currently nothing happens when pasting preformatted text in a list. This is better than nothing.
How?
Testing Instructions
Screenshots or screencast