Fluid Typography: add missing style.css file to test theme #44958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
ramonjd
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a tiny code quality follow-up, backporting part of the backport in WordPress/wordpress-develop#3431 for fluid typography:
Add missing
style.cssfile to theblock-theme-child-with-fluid-typographytest theme.Why?
While working on the core backport PR (WordPress/wordpress-develop#3431) some of the theme tests were initially failing, specifically the test_broken_themes() test. The
block-theme-child-with-fluid-typographytheme was unexpectedly in the array returned byget_broken_themes()because of its missingstyle.cssfile. Adding in the file resolved the failing test.While this PR will have no effect on the existing tests in Gutenberg, by adding this file in, we ensure that if we wind up adding theme-related tests at any point, whoever does that does not encounter unexpected theme errors.
How?
Add a missing
style.cssfile to the fluid typography test theme.Testing Instructions
style.cssfile matches that in core: https://github.com/WordPress/wordpress-develop/blob/64591219a0901220e9e34cd895df7739e097b76b/tests/phpunit/data/themedir1/block-theme-child-with-fluid-typography/style.css