Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit v7.0.0 promise-polyfill #4373

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Jan 10, 2018

Description

The previous URL 'https://unpkg.com/promise-polyfill/promise' . $suffix . '.js' was 404'ing

This change updates the URL to specifically use the 7.0.0 version of promise-polyfill

https://unpkg.com/promise-polyfill@7.0.0/dist/promise.min.js

This patch was proposed by @aduth in Slack here

See also Slack discussion: https://wordpress.slack.com/archives/C02QB2JS7/p1515522541000785

How Has This Been Tested?

Removed node_modules folder and ran npm install

Followed up by npm run package-plugin with terminal output:

https://unpkg.com/promise-polyfill@7.0.0/dist/promise.min.js
 > vendor/promise.min.0f2d5308.js ... done!

No errors observed and build generated successfully.

Screenshots (jpeg or gifs if applicable):

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround I proposed used the minified version for simplicity's sake.

We should still respect the $suffix variable, i.e.

'https://unpkg.com/promise-polyfill@7.0.0/dist/promise' . $suffix . '.js'

@ntwb
Copy link
Member Author

ntwb commented Jan 10, 2018

Updated Thanks @aduth, updated in 80a6b5d

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ntwb ntwb merged commit ed77861 into master Jan 10, 2018
@ntwb ntwb deleted the update/promise-polyfill-unpkg-url branch January 10, 2018 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants