Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial "templates" doc. #4367

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Add initial "templates" doc. #4367

merged 1 commit into from
Jan 9, 2018

Conversation

mtias
Copy link
Member

@mtias mtias commented Jan 9, 2018

Closes #4340.

@mtias mtias added the [Type] Developer Documentation Documentation for developers label Jan 9, 2018
@mtias mtias force-pushed the add/templates-doc branch from 574fb1c to 5a0ccd4 Compare January 9, 2018 11:06
@mtias mtias force-pushed the add/templates-doc branch from 5a0ccd4 to c0ba1ef Compare January 9, 2018 11:06
@mtias
Copy link
Member Author

mtias commented Jan 9, 2018

Let's iterate on this.

@mtias mtias merged commit 16bae00 into master Jan 9, 2018
@mtias mtias deleted the add/templates-doc branch January 9, 2018 17:24
@BinaryMoon
Copy link

Hi Matias. Looks good to me.

A few things I think would be good to include are:

  1. How to add a template to an existing post type (such as posts/ jetpack testimonials). I did this in my starter theme here but don't know if it's the best way: https://github.com/BinaryMoon/granule/blob/master/inc/gutenberg.php#L68-L99

  2. A note on how to find out what blocks are available. @youknowriad mentioned 'wp.blocks.getBlockTypes()' in Docs - Block Templates #4340 which is very helpful. I think if you want people outside of the core developers to start using/ implementing Gutenberg features then things like this need to be as visible as possible. Possibly this could be added to the blocks api as well/ instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants