-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize widgets: Fix top contents cutoff in keyboard shortcuts #43391
Merged
t-hamano
merged 1 commit into
trunk
from
fix/customizer-widgets-keyboard-shortcut-modal
Aug 23, 2022
Merged
Customize widgets: Fix top contents cutoff in keyboard shortcuts #43391
t-hamano
merged 1 commit into
trunk
from
fix/customizer-widgets-keyboard-shortcut-modal
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
CSS Styling
Related to editor and front end styles, CSS-specific issues.
[Feature] Widgets Customizer
Ability to add and edit blocks in Customize → Widgets.
labels
Aug 18, 2022
Size Change: -48 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
noisysocks
added
the
[Type] Code Quality
Issues or PRs that relate to code quality
label
Aug 23, 2022
noisysocks
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CSS Styling
Related to editor and front end styles, CSS-specific issues.
[Feature] Widgets Customizer
Ability to add and edit blocks in Customize → Widgets.
[Type] Code Quality
Issues or PRs that relate to code quality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fix top contents cutoff in keyboard shortcuts in the customize widgets.
Why?
I took the diff between the styles of edit-post or edit-site and found that only customizer-widgets had negative margins in the upper direction.
How?
I have removed this style.
I looked at #31970 where this style was applied and could not find any reason why this style was needed.
Testing Instructions
Trunk
After fixed