Blocks: Fix unsetting block alignment flagging block as invalid #4333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to resolve an issue where unsetting a block's alignment by clicking the currently selected value would cause the block to save as invalid.
Implementation notes:
A block with a defined attribute type will coerce its value to that type, except in the case that the value is
undefined
. Anull
value is therefore coerced since there may be cases where the developer wants to explicitly save an empty value into attributes. This is an issue for blocks using the alignment toolbar because previously the unset would set the alignment value tonull
, which would be coerced to the string type as"null"
(later serializing as<p style="text-align: null;"></span>
. The changes here respect this behavior, passingundefined
as the unset value when toggling the already-active alignment.Testing instructions:
Verify that upon toggling a block's alignment on and off, saving the post, and reloading the editor, the block appears as valid: