Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy in table of contents to describe the outline section. #4316

Merged
merged 1 commit into from
Jan 10, 2018

Conversation

mtias
Copy link
Member

@mtias mtias commented Jan 5, 2018

Now that the tooltip itself is called "table of contents" it makes more sense to describe this one as "document outline" instead:

image

@mtias mtias added [Type] Copy Issues or PRs that need copy editing assistance [Feature] Document Settings Document settings experience labels Jan 5, 2018
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise 👍

@youknowriad
Copy link
Contributor

youknowriad commented Jan 6, 2018

It's still not clear to me what's "Document Outline" and what's "Table of Contents".
As I understand it:

  • The table of contents is the list of titles
  • The document outline is the table of contents + the counts (the whole dropdown)
  • Also, there's the sidebar panel which right now is labeled as "Table of Contents"

According to the change in this PR, It might be the opposite though. So just wanted to ask for clarification and if we do the change in this PR, we should probably update the title in the sidebar and also merge #4309

@mtias
Copy link
Member Author

mtias commented Jan 10, 2018

Yes, it is kind of the opposite, it will stabilize soon enough :)

@mtias mtias merged commit 6a7241a into master Jan 10, 2018
@mtias mtias deleted the update/table-of-contents-outline-copy branch January 10, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Type] Copy Issues or PRs that need copy editing assistance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants