-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout: fix flex direction column #42939
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching that one. Must have slipped past us 😄
'align-items' => 'flex-start', | ||
$layout_styles[] = array( | ||
'selector' => $selector, | ||
'declarations' => array( 'flex-direction' => 'column' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, but should the align-items prop also come across?
'declarations' => array( 'flex-direction' => 'column' ), | |
'declarations' => array( 'flex-direction' => 'column', 'align-items' => 'flex-start' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we already have a duplicate 'align-items' => 'flex-start'
in the else condition below, so I think we were duplicating that output previously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for catching this one @matiasbenedetto! It turns out with #42452, I was testing the layout implementation using the Buttons block, which provides its own vertical orientation CSS, so it didn't catch this one in manual testing 🤦
We'll now know to properly test the Stack variation, too!
This LGTM, so I'll merge it in once the e2es pass. Thanks! 🙇
a64cad0
to
00b7cc9
Compare
I've just given this a rebase to get the e2e tests passing now that #42947 has been merged |
Fixes: #42938
What?
Fixing stacked (column/vertical) orientation of the row block.
Why?
The row element with stack orientation doesn't work since #42452 was merged.
Currently, the CSS related to the flex-direction is not rendered in the frontend.
How?
This PR fixes the styles engine to render the CSS to the flex-direction in the frontend.
Testing Instructions
Screenshots or screencast
Before:
After:
Fixes: #42938