Use @testing-library/user-event in BoxControl tests
#41422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
stokesman
commented
May 29, 2022
Comment on lines
+156
to
+161
| expect( spyChange ).toHaveBeenLastCalledWith( { | ||
| top: undefined, | ||
| right: undefined, | ||
| bottom: undefined, | ||
| left: undefined, | ||
| } ); |
There was a problem hiding this comment.
This test wasn't previously testing what onChange was called with. It seems appropriate to cover because even if the input remains empty, the feature may break as mentioned in #40518 (comment).
aaronrobertshaw
approved these changes
May 30, 2022
There was a problem hiding this comment.
These changes look great @stokesman. 👍
The tests are even easier to read and the increased coverage around the onChange handling is a win.
✅ Unit tests are passing
✅ No surprises in the code changes
✅ Current iOS e2e failure is unrelated
LGTM 🚢
youknowriad
pushed a commit
that referenced
this pull request
Jun 3, 2022
* Use @testing-library/user-event in `BoxControl` tests * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the
BoxControlunit tests to use@testing-library/user-eventfor interacting with the component and modifies one test to cover itsonChangehandling.Why?
How?
https://testing-library.com/docs/ecosystem-user-event/
Testing Instructions
npm run test-unit /box-control