-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block support docs: update blockGap notes #41225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, thanks for updating the docs @ramonjd, this reads well to me!
I was wondering if it'd be worth us also stabilising the __experimentalDefault
prop at the same time (switch it over to default
) based on this comment in the other PR: #41098 (review). What do you think? Worth stabilising, or is it still a little up in the air, given we're doing lots of layout exploration at the moment?
(From my perspective, we're exploring changing lots of things, but being able to set a default fallback value at the block level in block.json
probably isn't one of the main areas we're looking at changing up... 🤔)
Oh definitely, good point! I wasn't sure, and to be honest, probably just focussed on the "let's document this" part 🤣 I did notice we had nothing about |
Sorry for the late reply, I missed the notification! Yes, sounds good to remove the |
Removed reference to __experimentalDefault
Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read well to me, thanks for the improvement here!
* Iiitial commit * Updated to include __experimentalDefault * Cleaned up code examples Removed reference to __experimentalDefault * Update docs/reference-guides/block-api/block-supports.md Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com>
What?
Update block support docs to reflect the curiosities of block gap.
Why?
In response to an API update: #41098
How?
Keyboard