BorderRadiusControl: Tweak spacing between input and range control to line up with BorderControl #40958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +5 B (0%) Total Size: 1.24 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
May 10, 2022
There was a problem hiding this comment.
LGTM 👍
Thanks for cleaning this up. The sliders look more aligned now.
Note: The larger space to the right in the image above is due to the fact I left the drag handle fully to the left.
I think once the default height of all our controls change, we might wish to tweak the placement of the link/unlink buttons. In the border radius unlinked view it looks a little off given the second row of controls. Absolutely nothing to worry about now especially given the importance of having the default/linked view looking more consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While reviewing #40920, I noticed that the spacing between the
BorderControland its range control, and theBorderRadiusControland its range control looked slightly off. This PR gets them to line up horizontally, and adds a similar top margin to the unlink button so that it more approximates vertical alignment.Why?
Related to #40893, this attempts to improve consistency.
How?
BorderRadiusControlto match theBorderControl(a little more room ensures that the focused state of the slider doesn't brush against the input field).Testing Instructions
Add a Group block to a post and inspect the Border controls — look closely at the space between the input controls and the range sliders. They should be the same now.
Screenshots or screencast