Navigation Link: Avoid unnecessary re-renders #40696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -17 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
0551727 to
3586560
Compare
|
I cherry picked this change into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discovered while testing #40357.
The Navigation Link block was constantly re-rendering even when typing into a different block.
Why?
Re-rendering affected typing performance, especially if you've got a few large Navigation blocks on the page.
How?
The re-rendering issue was caused by
blockTransformschanging on every store update. TheNavigationLinkEditcomponent doesn't need this state, so I moveduseSelectinsideLinkControlTransforms.P.S. While this is a valid fix. As a follow-up, we might want to look into the
getBlockTransformItemsselector performance.Testing Instructions
Screenshots or screencast
Before
CleanShot.2022-04-28.at.21.16.21.mp4
After
CleanShot.2022-04-28.at.21.17.11.mp4