Add arrows to post navigation link #40684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.02 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
af08058 to
7333e7c
Compare
|
This is looking good. When the site is in RTL mode, the arrows are the wrong way round in the front end: In the query pagination block we dealt with this in CSS: Although that solution no longer seems to be working... |
|
The broken RTL style does seem to be a bigger problem. I tested the query pagination and the comment query pagination and the spacing and arrows are incorrect there too. Thank you for the rebase as well. |
|
I found that if I deactivate Gutenberg, the |
|
This is blocked by #41762 |
|
How can we move this forward? The rtl issue has not been reviewed or merged. |
d6c08b2 to
caab778
Compare
This was referenced Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds an option to add arrows to the post navigation links.
Fixes #35954
Why?
This is an enhancement that adds a new feature to the post navigation link to help users style their next and previous post links.
It matches the option that already exists for the next and previous links in the query pagination.
How?
Adds a new attribute called
arrowand a new toggle group option in the block settings sidebar.Testing Instructions
First make sure that your WordPress installation has a few posts so that you can test both the next and previous links.
In the editor, add the next and previous link blocks.
Duplicate the blocks enough times to test one each of the different settings.
Save and view the front.
Switch to a RTL language and repeat the test.
Screenshots or screencast
Editor:
