Post Comments Form: Fix layout quirks #40359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -249 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
|
Note that even with this change, the inline comment form still doesn't look great. Off the top of my head, I'd say that:
Maybe a designer can help with these (by adding styling to The challenge is that this shouldn't preclude any styling done by the user in the Site Editor, or through a themes styling. This means that it would need to be somewhat generic. (E.g. the comment textarea width is currently determined by the existing comments width; it probably should not become fully independent of that.) |
62d40e1 to
bdef658
Compare
|
I pushed a couple changes to tighten up the spacing and font size:
|
jffng
approved these changes
Apr 18, 2022
|
Thanks a lot @jffng! |
|
Cherry picked to the |
gziolo
pushed a commit
that referenced
this pull request
Apr 25, 2022
Co-authored-by: Jeff Ong <jonger4@gmail.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up to #40268.
Why?
When using the Comments Query Loop block and Post Comments Form block in a template, the comments form is rendered inline in the position where the user clicked 'Reply' on the frontend. However, there are still some layout quirks, as seen below:
First and foremost, the 'Cancel reply' link is way to close to the 'Reply to admin' text.
Compare this e.g. to the Twenty Twenty One (TT1) theme:
(This is achieved by a simple flexbox-based styling of
comment-reply-title.)How?
This PR attempts to fix them in a way that doesn't preclude any extra styling by themes.
For now, it only adds flexbox styling akin to TT1's to the Post Comments Form's
style.scss.Testing Instructions
Screenshots or screencast