Rename core-data/src/selectors.js to selectors.ts (TypeScript) #40026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
gziolo
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a subset of #39025 – a mega branch that proposes TypeScript signatures for all @wordpress/core-data selectors.
This PR renames
selectors.jstoselectors.tsand adjusts the related references in the documentation. It is the first step towards adding function signatures to these selectors.Testing Instructions
Confirm the checks are green. The changes here should only affect the type system so there is nothing to test in the browser.
cc @dmsnell @jsnajdr @youknowriad @sarayourfriend @getdave @draganescu @scruffian