Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Styles: Revert changing default overflow-wrap to all headers, lists, and paragraphs #39846

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

arthur791004
Copy link
Contributor

@arthur791004 arthur791004 commented Mar 29, 2022

What?

As #34222 tries to fix the overflow problem for the long strings of text without spaces, it changes the default overflow-wrap behavior to all headers, lists, and paragraphs and leads to some side effects.

Why?

As it changes the default behavior to all headers, lists, and paragraphs and leads to some side effects. See #34222 (comment), #34222 (comment), #34222 (comment)

How?

Revert the change of the default overflow-wrap behavior to all headers, lists, and paragraphs.

Testing Instructions

  1. Create or Edit a post
  2. Insert the following blocks
    • h1 through h6
    • ol and ul
    • p
  3. Make sure the overflow-wrap style doesn't affect these blocks.

Screenshots or screencast

@arthur791004 arthur791004 requested a review from ajitbohra as a code owner March 29, 2022 10:10
@priethor priethor added the Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json label Mar 29, 2022
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I think this revert makes sense.

For the original use case — a very long string of text with no spaces — I don't think breaking the word to prevent overflow warrants changing the default behavior for all list, paragraphs, and heading elements.

cc @jasmussen for a gut check.

@jasmussen
Copy link
Contributor

It seems good to let themes handle this 👍 👍

@jffng jffng merged commit f594f6c into WordPress:trunk Mar 29, 2022
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Mar 29, 2022
@arthur791004 arthur791004 deleted the fix/revert-some-of-34222 branch March 30, 2022 08:34
@arthur791004
Copy link
Contributor Author

Thanks for your quick review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants