e2e Tests: waitForNavigation in Comments Query Loop test
#39818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.22 MB ℹ️ View Unchanged
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In the Comments Query Loop e2e test, use
waitForNavigationrather thanwaitForSelector. (Follow-up to #39502.)Why?
After navigating from one page to another (via mouse click), we currently
waitForSelectorin order to make sure that a DOM element exists, before asserting that that DOM element exists. However, if it didn't exist,waitForSelectorwould have timed out and errored -- which means the assertion is redundant.How?
In order to keep the assertion and make it non-redundant, while also making sure the page has loaded before we attempt to find the corresponding DOM element, we replace
waitForSelectorbywaitForNavigation(which doesn't include any implicit assumptions about the specific DOM element being there).(First discussed here: #39502 (comment))
Testing Instructions
Verify that e2e tests pass (see CI). To verify locally:
To watch the test while it's ongoing, append
--puppeteer-interactiveto the above command.