Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg Data Tutorial] Part 3: Building an edit form #38581

Merged
merged 37 commits into from
Mar 2, 2022

Conversation

adamziel
Copy link
Contributor

@adamziel adamziel commented Feb 7, 2022

@adamziel adamziel added [Type] Developer Documentation Documentation for developers [Package] Core data /packages/core-data labels Feb 7, 2022
@adamziel adamziel self-assigned this Feb 7, 2022
@adamziel adamziel marked this pull request as ready for review February 8, 2022 14:28
Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 This is great stuff Adam. It's easy to follow and seems to cover off all the common pain points.

I learnt quite a few things myself!

Some nits and suggestions left.

docs/how-to-guides/data-basics/3-building-an-edit-form.md Outdated Show resolved Hide resolved
docs/how-to-guides/data-basics/3-building-an-edit-form.md Outdated Show resolved Hide resolved
docs/how-to-guides/data-basics/3-building-an-edit-form.md Outdated Show resolved Hide resolved
docs/how-to-guides/data-basics/3-building-an-edit-form.md Outdated Show resolved Hide resolved
docs/how-to-guides/data-basics/3-building-an-edit-form.md Outdated Show resolved Hide resolved
docs/how-to-guides/data-basics/3-building-an-edit-form.md Outdated Show resolved Hide resolved
@adamziel adamziel force-pushed the docs/data-basics-3-building-an-edit-form branch from 165b61e to a861e51 Compare February 17, 2022 16:04
@adamziel
Copy link
Contributor Author

I rebased and addressed the feedback. Would you mind re-reviewing @getdave? 🙏

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads really well.

I've left some minor suggestions and nits but otherwise I'd say this is good to go 🚢

adamziel and others added 17 commits March 2, 2022 16:28
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
…cted in the PageList before you were ready to "commit" or persist them.
@adamziel adamziel force-pushed the docs/data-basics-3-building-an-edit-form branch from dd763ff to 540721f Compare March 2, 2022 15:28
@adamziel
Copy link
Contributor Author

adamziel commented Mar 2, 2022

@getdave I'll go ahead and ship this. I'd still love to hear your feedback – I'll address any notes you may have in a follow-up PR.

@adamziel adamziel merged commit e261262 into trunk Mar 2, 2022
@adamziel adamziel deleted the docs/data-basics-3-building-an-edit-form branch March 2, 2022 16:32
@github-actions github-actions bot added this to the Gutenberg 12.8 milestone Mar 2, 2022
@getdave
Copy link
Contributor

getdave commented Mar 4, 2022

Thanks for addressing all the feedback. Another great resource shipped.

👏👏👏👏👏👏👏👏👏👏👏👏👏👏

adamziel added a commit that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Core data /packages/core-data [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants