-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gutenberg Data Tutorial] Part 3: Building an edit form #38581
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 This is great stuff Adam. It's easy to follow and seems to cover off all the common pain points.
I learnt quite a few things myself!
Some nits and suggestions left.
165b61e
to
a861e51
Compare
I rebased and addressed the feedback. Would you mind re-reviewing @getdave? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads really well.
I've left some minor suggestions and nits but otherwise I'd say this is good to go 🚢
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
…cted in the PageList before you were ready to "commit" or persist them.
dd763ff
to
540721f
Compare
@getdave I'll go ahead and ship this. I'd still love to hear your feedback – I'll address any notes you may have in a follow-up PR. |
Thanks for addressing all the feedback. Another great resource shipped. 👏👏👏👏👏👏👏👏👏👏👏👏👏👏 |
…)" This reverts commit e261262.
This PR introduces the next part of Create your First App with Gutenberg Data tutorial – the focus is on editing data.
Rich-text preview
All feedback is very welcome!
cc @getdave @bph @ironprogrammer @ryanwelcher @mkaz @youknowriad @gziolo @talldan @tellthemachines @draganescu @gziolo @youknowriad @talldan @annezazu @noisysocks