-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Add optional custom editor component to native test helper #38133
Merged
fluiddot
merged 3 commits into
trunk
from
rnmobile/add/initialize-editor-helper-custom-component
Jan 21, 2022
Merged
[RNMobile] Add optional custom editor component to native test helper #38133
fluiddot
merged 3 commits into
trunk
from
rnmobile/add/initialize-editor-helper-custom-component
Jan 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Jan 21, 2022
Size Change: +37 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
2 tasks
dcalhoun
approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 LGTM. I left one comment regarding a possible refactor to consider, but it should not be consider a blocker if you would prefer to merge as-is.
dcalhoun
approved these changes
Jan 21, 2022
fluiddot
deleted the
rnmobile/add/initialize-editor-helper-custom-component
branch
January 21, 2022 16:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include an optional argument to
initializeEditor
native helper, this will allow us to provide a different Editor component when initializing the editor, which is required for tests done in Gutenberg Mobile, where we provide a custom Editor component.How has this been tested?
This change shouldn't affect current tests, but we could double-check that all tests pass by running the command
npm run native test
.Screenshots
N/A
Types of changes
Improvement
Checklist:
*.native.js
files for terms that need renaming or removal).