Require stylelint v14 for stylelint config and scripts #38091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocean90
commented
Jan 19, 2022
ocean90
commented
Jan 19, 2022
ocean90
commented
Jan 19, 2022
|
Size Change: 0 B Total Size: 1.13 MB ℹ️ View Unchanged
|
ntwb
approved these changes
Jan 19, 2022
Comment on lines
+25
to
+28
| // stylelint-disable no-invalid-position-at-import-rule | ||
| @import "../some/url"; | ||
| @import "../another/url"; | ||
| // stylelint-enable no-invalid-position-at-import-rule |
There was a problem hiding this comment.
With the addition of packages/stylelint-config/test in .stylelintignore in his PR at https://github.com/WordPress/gutenberg/pull/38091/files#diff-36ae73c99ebd1b4072a3164e014df72eb094703df4548dd51938aa7faaa7f8d2R1 are the ignore directives needed here?
There was a problem hiding this comment.
Yes, the .stylelintignore is only used when running npm run lint-css in the project root but not when running npm run test-unit packages/stylelint-config for the tests.
The rule is new in v5, see stylelint-scss/stylelint-config-recommended-scss@1e40cc1. Instead of removing the lines I added the comments for now.
gziolo
approved these changes
Jan 20, 2022
|
@ocean90, it looks like the recently merged Jest major version upgrade introduced merge conflict. The good news is that we should be up to date with most of the tools used in |
058744c to
075ec59
Compare
|
I have rebased the branch. 🤞 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up for #36518. As mentioned by @WraithKenny in #36514 (comment) the current dependencies are not compatible with v14. Therefore we should increase the minimum peer dependency of
stylelintto14.2.0and thus update scripts to use v14 too.While working on this I noticed that the current stylelint repo in this config was not using the SCSS preset. This seems to be the reason why suddenly a few errors came up since I had to switch to the SCSS preset otherwise stylelint is no longer able to parse SCSS files, see official migration guide to v14 for details.
To update dependencies the I have followed the steps mentioned in https://github.com/WordPress/gutenberg/blob/HEAD/packages/README.md.
How has this been tested?
Manually by running
npm run lint-cssin the project.Screenshots
Types of changes
Breaking change
Checklist:
*.native.jsfiles for terms that need renaming or removal).