Fix missing default align-items
when items are oriented vertically in flex
layout
#38069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an alternative approach to #37986, which actually fixes the root issue. Thanks @ntsekouras for spotting this!
For blocks that support the ability to orient items vertically, by default there is no
justifyContent
attribute applied. In the Editor, when there is no attribute we are applyingalign-items: flex-start
as a default. On the frontend however, there is no default which leads to some rendering errors, particularly with the Social Icons block. This PR addsalign-items: flex-start
to the frontend when there is nojustifyContent
attribute and the block is meant to be oriented vertically.How has this been tested?
Screenshots
Without this PR
With this PR
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).