Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo (hanle -> handle) #37849

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix typo (hanle -> handle) #37849

merged 1 commit into from
Jan 11, 2022

Conversation

aristath
Copy link
Member

@aristath aristath commented Jan 11, 2022 •
edited
Loading

Description

There's a typo in the wp_enqueue_block_style function (hanle instead of handle).
This PR fixes the typo and should be backported to WP 5.9 since we have the same issue there as well.

Types of changes

  • Fixed typo

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).
  • I've updated related schemas if appropriate.

@aristath aristath added [Type] Bug An existing feature does not function as intended Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Jan 11, 2022
@aristath aristath requested review from Mamaduka, gziolo and a team January 11, 2022 08:08
gziolo
gziolo approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@Soean
Copy link
Member

Soean commented Jan 11, 2022

Same issue was reported in trac: https://core.trac.wordpress.org/ticket/54786

@aristath
Copy link
Member Author

aristath commented Jan 11, 2022 •
edited
Loading

Same issue was reported in trac: https://core.trac.wordpress.org/ticket/54786

Ah great! So we already have the patch for core there 👍
I just came across the typo while working on #37848 😆

@aristath aristath merged commit 28e8d62 into trunk Jan 11, 2022
@aristath aristath deleted the fix/handle-typo branch January 11, 2022 08:55
@github-actions github-actions bot added this to the Gutenberg 12.4 milestone Jan 11, 2022
@noisysocks
Copy link
Member

Since has been fixed in Core (https://core.trac.wordpress.org/changeset/52560) just noting to my future self that I need only merge this into wp/5.9 and not do any actual backporting.

@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Jan 17, 2022
noisysocks pushed a commit that referenced this pull request Jan 17, 2022
@aristath @noisysocks
fix typo (#37849)
d983416
@noisysocks noisysocks mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@Soean Soean Soean approved these changes

@Mamaduka Mamaduka Awaiting requested review from Mamaduka

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 12.4
Development

Successfully merging this pull request may close these issues.
4 participants
@aristath @Soean @noisysocks @gziolo