Comments Pagination Next block: fix accidental division by zero #37788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Carlos 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
It fixes #37785, a small bug of the Comments Pagination Next block that triggers a
division by zerowarning when noper_pagewas set in either the parent Comments Query Loop block or in the WordPress settings.Why
Under those conditions, it was possible to run a division by zero in the code.
How
I replaced an
isset( $per_page )which always returns true for a comparison of0 !== $per_page.How has this been tested?
I tested it manually by adding a new Comment Query Loop block in a WordPress site with the default comments configuration.
Screenshots
I made a small video to explain the problem and this possible solution in more detail: https://www.loom.com/share/3aa2b9d8ab73417bac074a7c7d84cd50
Types of changes
This is a bug fix.
Checklist: