Template Editor Mode: Hide editor mode switcher #37359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Dec 14, 2021
|
Thanks for testing, @carolinan. I agree this is a short-term solution. Let's try to solve #22528 in the next release. @noisysocks should we backport this into beta 4? |
|
Is there a decision about the backport? |
|
|
I think it's okay to backport this. It's not a significant code change. |
|
Since it is currently broken, I think it would be more confusing if the short term fix is not backported. |
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #37320.
Code Editor isn't supported in Site Editor nor correctly works in the Template Editing Mode. PR hides editor mode switcher. We should enable this feature back once Code Editor mode is fully supported - #22528.
How has this been tested?
Screenshots
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).