Gallery block: enable the new gallery block by default if running in core #37134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
noisysocks
approved these changes
Dec 6, 2021
83ecd12 to
9f780a7
Compare
|
I rebased this to (hopefully) fix failing tests. |
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
…core (#37134) * Enable the new gallery block by default if running in core and not plugin * Add explanatory comment Co-authored-by: Glen Davies <glen.davies@a8c.com>
This was referenced May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a check to see if running in plugin in core, and only check Gallery block version compatibility if in plugin, otherwise enable the new version by default
How has this been tested?
Add a v1 gallery block to a site with use_balanceTags enabled
Check out this PR and make sure the block remains in v1 format and new blocks added are v1
Turn off the use_balanceTags option and check that the v1 blocks migrate to v2 and new blocks are v2 format