Block Styles: add preview pane to widget editor #37012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +13 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
|
🥳 Thanks for this! It's testing well for me -- I applied the fix in #37010 first to get past the blocks crashing, and now I'm able to see the style previews working well in both the block editor and the widget editor. There is one other place where the style previews aren't working -- when you edit widgets in the customizer by going to
I'm not very familiar with the customizer so I'm not sure if the fix there would be as straightforward? |
Thanks for testing @stacimc I'll look into it. I'm not sure whether it would be straightforward either, but my instinct is to say that your instinct is right 😄 If it's too hairy to append to this PR's changes, I'll open a new PR for it. |
646a034 to
8142c8e
Compare
This one is tricky. I think we'd need to find the right container to be able to position things correctly, and then meddle with the CSS to suit the specific context of the Customizer.
Ideally the preview would hover over the Customizer iframe. The challenge is to find the right relatively-positioned parent and not break anything else 😄 I'm leaning towards looking at this in another PR for now, particularly since the block settings aren't immediately available/visible. |
kevin940726
approved these changes
Dec 2, 2021
|
As for in the customizer, I believe it's just a matter of managing stacking context. I think we are already rendering some popovers to a higher stacking context than the preview frame, so maybe just render this there? |
stacimc
approved these changes
Dec 2, 2021
…nce that's where the fill originates from. Adding the block styles slot to the widget editor so we can preview block styles in /wp-admin/widgets.php
8142c8e to
786c758
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
¡Hola! y Guten BergTag!
We added block style previews to the Block Editor in #34522
Now it's time to spread the warm and gooey joy of block style previews to the widget editor.
This PR does a couple of things:
/wp-admin/widgets.phpblock-inspectoras the context for the block styles slot since that's where the fill originates from (and so it can work across editors)Testing
You can follow the test instructions over at #34522
But the gist of it is:
/wp-admin/widgets.php)Props to @stacimc for nudging us on this one! 🙇
Types of changes
Enhancement. Adding existing feature to the Widgets Editor.
Checklist:
*.native.jsfiles for terms that need renaming or removal).