-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Clear customizations' button to template list page #36802
Merged
Merged
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main outstanding issue seems to be that
revertTemplate
doesn't actually save the edited entity records to complete the reversion. The listing page doesn't update because of that.It's really designed for use in the editor where there's a separate save button. It also treats the revert as something that can be undone. That may be more difficult to achieve here if we have to save the changes.
The options here:
revertTemplate
so that it accepts additional params to make it work on this screenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, not that it's preferred, add the entity saving workflow to this screen too. I think it would look weird though.
Could we add an optional option
force: true
to indicate that it should save immediately after edited? If that doesn't work we can create a separate action for it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented something similar to
force: true
but I didn't like how it means that passing an argument completely changes the behaviour of the action.Ideally I'd split
revertTemplate
up into two functions—one that saves, one that doesn't—and have them both call into a private action which does the entity editing bits. This is really difficult to do unless we changeedit-site
to use thunks, though.So instead I went with e9e7ede which has the button immediately save the entity after reverting. I added a
allowUndo
option so that the success notice, when we implement notices, doesn't allow the user to undo something that's been already saved.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also inform users that this is an irreversible action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think let's follow up on that. I see "Ability to undo an action" on the list (#36597). We have the same problem with the Remove action.