-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page list to navigation direct insert conditions #36591
Conversation
Size Change: +4 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love tiny PRs like these 👌
The change makes sense for us to try, as when you're looking at a menu with only menu items, you'd expect it to behave like the other manually curated menus you've created.
As part of the rolling out of the navigation block, I suspect we'll get a slew of good feedback, and depending on that we can always revisit this one. But it seems good to start with this one as a baseline.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Makes a big different to positive UX. Glad it was such a quick fix.
Description
Currently, it is only possible to directly insert links in the Navigation block if there are only link or submenu items in it. This PR adds Page List to those items, so that links can also be directly inserted when the nav has a page list in it.
How has this been tested?
Create a Navigation block, choosing "Add all pages" option. Verify that clicking the inserter adds a link block directly, instead of showing the quick inserter.
Screenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.js
files for terms that need renaming or removal).