Post Comments Form: ensure typography styles are applied to child elements #36425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s from typography inline styles on the block's container
|
Size Change: +547 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
Thanks for following up on this one @ramonjd! I like the approach. Unfortunately, I ran out of time to test this, so will follow-up on Monday 😀 |
carolinan
reviewed
Nov 13, 2021
Moved comment down to the code block it describes
andrewserong
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
This looks good to me @ramonjd, thanks for following up on the issue!
✅ This change allows each of the Typography styles to affect the heading within the comments form
✅ Setting a Typography setting to its default value restores the styling defined in the theme (e.g. the heading font size)
✅ It's now possible to set some consistent simple styling across the rendered form, e.g.
As you mention, longer-term, it would be good to explore creating a core block (or blocks) to replace the generated comments form, and allow granular control over the headings, button, and link styles, but this PR adds in a good bit of consistency in the shorter-term. LGTM 👍
Thanks for reviewing @andrewserong ! I won't take credit: it was your idea. 🙇 |
noisysocks
pushed a commit
that referenced
this pull request
Nov 22, 2021
…ments (#36425) * New CSS declarations to ensure that the post comments heading inherits from typography inline styles on the block's container * Font size can also be determined by a CSS class * Update style.scss Moved comment down to the code block it describes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch introduces some wildcard CSS selectors to ensure that the post comments heading inherits from typography inline styles on the block's container.
Resolves #36188
A more long-term approach might be to create a core block to replace the comments form.
How has this been tested?
Using TT1/TwentyTwenty[One|Two], insert a Post Comments Form Block and play around with the typography controls for that block.
Publish the post and ensure that all the typography styles overwrite the theme's defaults.
Types of changes
Adding CSS declarations
Checklist:
*.native.jsfiles for terms that need renaming or removal).