Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early List block implementation (no UI yet) #358

Merged
merged 17 commits into from
Apr 7, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added i18n string for list
  • Loading branch information
mimo84 committed Apr 7, 2017
commit e370326831ba18fe231d466dfdec2c2b0f2d5168
2 changes: 1 addition & 1 deletion editor/blocks/list/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const Editable = wp.blocks.Editable;
const { html, prop } = wp.blocks.query;

wp.blocks.registerBlock( 'core/list', {
title: 'List',
title: wp.i18n.__( 'List' ),
icon: 'editor-ul',
category: 'common',

Expand Down
10 changes: 7 additions & 3 deletions languages/gutenberg.pot
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,17 @@ msgstr ""
"Content-Type: text/plain; charset=utf-8\n"
"X-Generator: babel-plugin-wp-i18n\n"

#: editor/header/mode-switcher/index.js:31
msgctxt "Name for the Text editor tab (formerly HTML)"
msgid "Text"
msgstr ""

#: editor/blocks/freeform/index.js:4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also: #377

We could probably skip these changes. I'll hope to tackle this in the next day.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, on the topic of localization, we should localize the block's title.

See text bock as example:

https://github.com/WordPress/gutenberg/blob/f1b8d8d/editor/blocks/text/index.js#L5

msgid "Freeform"
msgstr ""

#: editor/header/mode-switcher/index.js:31
msgctxt "Name for the Text editor tab (formerly HTML)"
msgid "Text"
#: editor/blocks/list/index.js:5
msgid "List"
msgstr ""

#: editor/header/mode-switcher/index.js:30
Expand Down