-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Early List block implementation (no UI yet) #358
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f565b8c
text and list blocks
ephox-mogran f35c593
starting with list blocks
ephox-mogran 3e96e6e
list-block: Trying a possible approach with lists
mimo84 ecf4e28
list-block: Saving and editing lists
mimo84 a6b4e9f
list-block: restored original inserter
mimo84 ce33c03
Merge remote-tracking branch 'origin' into list-block
mimo84 374fb7b
Fixing PR comments:
mimo84 7c7af5f
List icon in block inserter
mimo84 67ed22d
Added sample content for list
mimo84 06c44d7
merge conflict
mimo84 6a42a5d
Fixed linting
mimo84 c8bf285
Merge branch 'master' into list-block
mimo84 69aa433
Merged master
mimo84 68427de
Removed nodeName from default properties
mimo84 b00b4b8
Added changes as per PR comments
mimo84 821ac5d
restored pot file as per master
mimo84 e370326
Added i18n string for list
mimo84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Added i18n string for list
- Loading branch information
commit e370326831ba18fe231d466dfdec2c2b0f2d5168
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also: #377
We could probably skip these changes. I'll hope to tackle this in the next day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, on the topic of localization, we should localize the block's title.
See text bock as example:
https://github.com/WordPress/gutenberg/blob/f1b8d8d/editor/blocks/text/index.js#L5