Submenu item paddings & fixes #35716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ec30893 to
c2a9a50
Compare
|
Size Change: +7 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
This PR fixes some important features of the submenu/hover/click behavior of the navigation block, making it behave consistently, so it would be good to land this one. One thing that became more clear to me working on this one, was that when submenus are set to open on click, this behavior applies all the way down the stack, rendering the nested submenu containers inert as well. I would say this is correct behavior, as it allows you to create nested submenus where the in-between item serves as a group rather than item on its own:
This is similar to how MacOS nested submenus work, in the following screenshot, the "Sort by" item isn't clickable on its own, and serves only to group the submenu items:
It is likely not going to be a behavior that trips people most of the time, but noting for posterity that it's something we could revisit in the future, for example by adding contextual help text below the toggle that explains that it makes items inert. Here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #35654.
Nested submenus did not show up when the navigation block was set to open on click. This PR fixes that:
In addition to that, and in this PR being a replacement of #35660, it also fixes:
Before:
After:
How has this been tested?
Create a menu with submenus and nested submenus. Ensure all pages added are published, not drafts. Set the menu to open on click:
Here's some test content:
Please test that both in the editor and on the frontend, nested submenus open as intended, on click.
Hover should be unaffected, but for good measure, test that hover/focus to open nested submenus works as well.
Checklist:
*.native.jsfiles for terms that need renaming or removal).