-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover: Update 'templateLock' attribute #35671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Block] Cover
Affects the Cover Block - used to display content laid over a background image
[Type] Enhancement
A suggestion for improvement.
labels
Oct 15, 2021
Size Change: +27 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
add/cover-template-lock-attr
branch
from
October 18, 2021 11:08
2a7fe02
to
3abc626
Compare
ntsekouras
approved these changes
Oct 18, 2021
Thanks for the review, @ntsekouras. |
Mamaduka
changed the title
Cover: Add 'templateLock' attribute
Cover: Update 'templateLock' attribute
Oct 18, 2021
Mamaduka
added
[Type] Bug
An existing feature does not function as intended
and removed
[Type] Enhancement
A suggestion for improvement.
labels
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Cover
Affects the Cover Block - used to display content laid over a background image
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds thetemplateLock
attribute to the Cover block. It will allow the locking of the Cover to be controlled by templates and patterns.PR updates the
templateLock
to useenum
type instead of thestring
, similar to Group and Columns blocks.Similar to #29916.
How has this been tested?
Using the following snippet, verified that template locking works on the block and inner blocks.
Types of changes
Enhancement
Checklist:
*.native.js
files for terms that need renaming or removal).