[Block: Post Navigation Link] Add an option for displaying the label inside the link #34952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itle and the label be a part of the link
|
Size Change: -599 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
|
I was AFK, I will have a look asap |
|
This doesn't seem to be working for me on the frontend: Editor: Frontend: Also, it looks a bit weird that the title of the post is not showing as a link on the editor, but that was happening before your changes too. |
|
I was not able to reproduce the problem. Here is some sample content for testing: |
|
I don't know what was happening but now it works! Thank you for this Carolina! I have a nitpick (also not related to your code!) and it's that when the label is not a link, in the editor it's still wrapped around an anchor tag, and showing links styles. I'm happy if you want to merge this and we fix that elsewhere. I tried with emptytheme this time: Frontend: |
MaggieCabrera
approved these changes
Sep 28, 2021
oandregal
reviewed
Oct 25, 2021
| $label = 'next' === $navigation_type ? _x( 'Next:', 'label before the title of the next post' ) : _x( 'Previous:', 'label before the title of the previous post' ); | ||
| $link = sprintf( | ||
| /* translators: 1: label. 2: post title */ | ||
| __( '<span class="post-navigation-link__label">%1$s</span> <span class="post-navigation-link__title">%2$s</span>' ), |
There was a problem hiding this comment.
👋 @carolinan @MaggieCabrera I was doing some translation work and run into this string. I'm not sure if I'm missing something but I don't see anything here that needs to be translated. Can we remove _() from here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Block: Post Navigation Link] Add the ability to have both the text title and the label be a part of the link
Closes #29032
Description
An option to include the label as part of the link is displayed when the display the title as a link option is enabled.
With the PR, the following scenarios will be possible:
How has this been tested?
Add a custom label and retest the options.
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).