Fix undo/redo 'trap' in navigation link block #34565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2021
|
Size Change: +622 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
Thanks for taking care of this. I can confirm it's broken in trunk:
And that this branch fixes it:
I would encourage another code sanity check from someone more familiar with the code than myself, but if you have high confidence in this one, the amount of changes is beautifully small. Thanks.
|
Thanks, it is a pretty small change, so I'll take that 👍 and merge. |
7 tasks
2 tasks
3 tasks
7 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34564
There's some code in the navigation link block that calls
setAttributewithin a react effect. It causes a bug that means the user cannot click 'redo' after clicking 'undo'.What happens here is hard to explain, but there is a good reason why this happens and an appropriate fix.
The best way to explain it is to first mention how the 'undo' feature generally works. If I click undo a few times as a user, but then make a change (type something in) I lose my ability to click 'redo'. Essentially what I just typed in becomes the new undo history. That's correct and how the feature has historically worked across various applications.
This react effect is causing the same thing. The user clicks undo a few times, the side effect triggers and the undo history is changed. The user is no longer able to click redo, but this time it wasn't caused by the user.
The appropriate fix seems to be to use
__unstableMarkNextChangeAsNotPersistentto indicate that the attribute change shouldn't update the 'undo' history.How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).