Fix gray W menu color. #34318
Merged
Fix gray W menu color. #34318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -20 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From the department of subtleties, this PR makes a barely perceptible but still important change. Here's the post editor W menu:
Here's the site editor W menu:
Spot the difference? Here's a zoomed version of the site editor menu:
Notice how there's a cold-gray halo, and how the black square does not overlap the gray border below.
This PR unifies the appearance of both, so they are both the same height, same color, and with no halo:
One thought this PR surfaces: it would be really nice if we could reduce the drift between the two editors, so improvements to one benefits the other, rather than all this code duplication going on.
How has this been tested?
Please test that the post editor and site editor W menus look the same.
Checklist:
*.native.jsfiles for terms that need renaming or removal).