Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align labels on focal point picker position controls above the inputs #34209

Merged

Conversation

chad1008
Copy link
Contributor

Description

Fixes #33563.

This PR relocates the 'Left' and 'Top' input labels on the Focal Point Picker to the top of the input field, rather than having them beside it.

With labels beside the inputs, the text can become longer when translated, which truncates the input field itself and making the value unreadable (see below for an example of Gutenberg in Spanish, where Izquierda is sufficiently long enough to cause the issue).

How has this been tested?

Tested manually, I've added a Cover block to a new post before and after the change to confirm the new placement.

Screenshots

Before:
126246384-f2ed83cf-c2a0-4615-b1f1-61d59b37e9e3

After:
Screen Shot 2021-08-20 at 5 07 10 PM

Types of changes

UI Bug Fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • N/A My code has proper inline documentation.
  • N/A I've included developer documentation if appropriate.
  • N/A I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

…nputs to allow space for longer text when translated
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Aug 20, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @chad1008! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@getsource getsource added [Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended [Package] Components /packages/components and removed First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Aug 25, 2021
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @chad1008! Congrats on your first contribution.

@talldan talldan merged commit 9a83b74 into WordPress:trunk Aug 25, 2021
@github-actions github-actions bot added this to the Gutenberg 11.5 milestone Aug 25, 2021
@chad1008 chad1008 deleted the fix/focal-point-picker-label-alignment branch August 25, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field text on background Block is too small
3 participants