Emulate reduced-motion in e2e tests #34132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7.95 kB (+1%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Aug 18, 2021
| @@ -240,6 +240,9 @@ beforeAll( async () => { | |||
| await trashAllPosts( 'wp_block' ); | |||
| await setupBrowser(); | |||
| await activatePlugin( 'gutenberg-test-plugin-disables-the-css-animations' ); | |||
There was a problem hiding this comment.
I think this means we can remove that plugin no?
There was a problem hiding this comment.
Yep, but I'd rather keep it for a while though. As mentioned in the original issue, I don't think we're quite there yet to disable this plugin entirely. Disabling it now would probably slow down the tests a little too.
youknowriad
reviewed
Aug 18, 2021
youknowriad
reviewed
Aug 19, 2021
| process.env.FORCE_REDUCED_MOTION || IS_IE | ||
| ? () => true | ||
| : () => useMediaQuery( '(prefers-reduced-motion: reduce)' ); | ||
| const useReducedMotion = IS_IE |
There was a problem hiding this comment.
I think we can remove the is_ie check now :)
This was referenced Oct 13, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally brought up in #33317 (comment). Emulate
prefers-reduced-motion: reducein e2e tests.How has this been tested?
E2E tests should pass
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).