Automated Changelog: Sort feature groups by issue name #34071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +197 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
7b6e928 to
877142a
Compare
gziolo
commented
Aug 13, 2021
|
|
||
| #### Widgets Editor | ||
| - Add error boundaries to widget screens. ([33771](https://github.com/WordPress/gutenberg/pull/33771)) | ||
|
|
||
| #### Patterns | ||
| - Block patterns: Add translation context on titles. ([33734](https://github.com/WordPress/gutenberg/pull/33734)) | ||
| - Block Add translation context on titles. ([33734](https://github.com/WordPress/gutenberg/pull/33734)) |
There was a problem hiding this comment.
This one is strange, but I haven't found an easy way to tweak the regular expression.
There was a problem hiding this comment.
I left a suggestion above to prevent this. It would still output Block patterns as a feature in the Patterns section unless we start over-optimizing the expression with things like (Block(s)?\s*)?, which seems overkill and not worth the extra polishing time it represents.
There was a problem hiding this comment.
Applied. It works perfectly fine 👍🏻
priethor
approved these changes
Aug 13, 2021
|
|
||
| #### Widgets Editor | ||
| - Add error boundaries to widget screens. ([33771](https://github.com/WordPress/gutenberg/pull/33771)) | ||
|
|
||
| #### Patterns | ||
| - Block patterns: Add translation context on titles. ([33734](https://github.com/WordPress/gutenberg/pull/33734)) | ||
| - Block Add translation context on titles. ([33734](https://github.com/WordPress/gutenberg/pull/33734)) |
There was a problem hiding this comment.
I left a suggestion above to prevent this. It would still output Block patterns as a feature in the Patterns section unless we start over-optimizing the expression with things like (Block(s)?\s*)?, which seems overkill and not worth the extra polishing time it represents.
Co-authored-by: Héctor <27339341+priethor@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #33719.
Each feature group is now sorted by name. To make the experience better, if there is a feature name in the title of the issue it gets removed.
Example:
How has this been tested?
How has this been tested?
The snapshot in the unit test got updated to reflect the latest changes.
Run
npm run changelog -- --milestone="Gutenberg 11.3"and you should see the same changelog generated.Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).