Fix duotone on fixed and repeated cover backgrounds #34021
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31662
The duotone filter should work with fixed and repeated backgrounds.
For duotone to be applied to an element, that element cannot contain child elements or the duotone will also be applied to the children, so the block markup had to change to accommodate that by having a separate
div
for the background to apply the duotone to.How has this been tested?
Since this is changing the saved markup, make sure deprecations work by creating a block prior to applying this PR and then upgrading the block.
Screenshots
TODO
Types of changes
Breaking change for the generated cover block markup.
Checklist:
*.native.js
files for terms that need renaming or removal).