-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Feature
mapping in automatically generated changelog
#33625
Conversation
Size Change: -113 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see more improvements in this direction!
Not directly tied to this PR, but one more thing we need to reevaluate is the precedence of feature types. For example, because the sortType
function gives more precedence to labels with a lower index in LABEL_TYPE_MAPPING
, a PR with both [Type] Bug
and Documentation
will get grouped with bugs. In practice, this has been the other way around in recent releases.
Description
In #33229 we introduced a mechanism which attempts to automatically assign PRs to a given "Feature" within each section.
Previously this task was completed manually so this was a good step forward.
Note we do not need to manually map all features. Anything marked with a Block specific label will be mapped to
Block Library
. Similarly anything labelled with[Feature] X
label will be automatically mapped to a feature namedX
(or whatever the name of the feature in the label is).Despite this however, the mapping is currently rather bare bones and needs augmenting. Some
[Feature]
labels are best mapped to a specific feature. Manual intervention is required.To this end this PR adds additional mapping of Github labels to the feature we feel best matches.
Please feel free to submit additional mappings either by:
The mapping is easily improved by cross referencing the human-made mapping that @gwwar undertook for
11.1.0
. Let's look at how she mapped the PRs to features and cross reference the labels. From that we shoudl be able to tell which labels are best mapped to which features.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.js
files for terms that need renaming or removal).